client/windows integration tests: plumbing work for running on windows #4432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
profnandaa
force-pushed
the
windows/integration-tests
branch
2 times, most recently
from
63a40d1
to
95b60bf
Compare
gabriel-samfira
requested changes
Nov 22, 2023
vendor/github.com/containerd/containerd/pkg/dialer/dialer_windows.go
Outdated
Show resolved
Hide resolved
profnandaa
force-pushed
the
windows/integration-tests
branch
6 times, most recently
from
c56c6d4
to
e0946b6
Compare
|
@profnandaa Some linter errors in CI. |
profnandaa
force-pushed
the
windows/integration-tests
branch
3 times, most recently
from
2ec9a5f
to
12327fe
Compare
Co-authored-by: Gabriel Samfira <[email protected]> This PR does most of the plumbing work requred for us to start running integration tests on Windows. We will need this to land before we can do the follow-up PRs to handle the specific tests. Signed-off-by: Anthony Nandaa <[email protected]>
profnandaa
force-pushed
the
windows/integration-tests
branch
from
12327fe
to
414edfa
Compare
@tonistiigi -- fixed. was a build directive mismatch on one file |
crazy-max
approved these changes
Nov 27, 2023
tonistiigi
reviewed
Nov 28, 2023
| "testing" | ||
| ) | ||
|
|
||
| func checkRequirement(t *testing.T) { |
There was a problem hiding this comment.
Not for this PR but looks like this function is not named correctly.
jedevc
reviewed
Nov 28, 2023
profnandaa
added a commit
to profnandaa/buildkit
that referenced
this pull request
Nov 30, 2023
The idea is to skip all tests for now, since they were originally meant for Linux. Then we will comb through each, enabling them for Windows and making necessary changes. This will make sure that all tests are fully considrered for Windows, and some do not just pass as false positives. Depends on: moby#4432 Co-authored-by: Gabriel Samfira <[email protected]> Signed-off-by: Anthony Nandaa <[email protected]>
profnandaa
force-pushed
the
windows/integration-tests
branch
from
4cdae01
to
64c5718
Compare
profnandaa
force-pushed
the
windows/integration-tests
branch
6 times, most recently
from
5396720
to
c930371
Compare
|
Fixed, ready for review. |
profnandaa
force-pushed
the
windows/integration-tests
branch
3 times, most recently
from
8600d9a
to
630b062
Compare
profnandaa
changed the title
profnandaa
changed the title
profnandaa
changed the title
profnandaa
force-pushed
the
windows/integration-tests
branch
from
630b062
to
dd34e58
Compare
gabriel-samfira
requested changes
Dec 7, 2023
NOTE: all these follow-up commits will be squashed after the review is done. What changed in this commit: - refactor the code to make the dial retry logic be the same across platforms. - a number of code duplication fixes and refactors Signed-off-by: Anthony Nandaa <[email protected]>
profnandaa
force-pushed
the
windows/integration-tests
branch
from
dd34e58
to
68afa16
Compare
|
@gabriel-samfira -- thanks for the review, fixed all the issues raised, ptal. |
gabriel-samfira
approved these changes
Dec 7, 2023
tonistiigi
approved these changes
Dec 7, 2023
|
Thanks for the merge! Will proceed to the next one towards having the integration tests CI enabled on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does most of the plumbing work required for us to start running integration tests on Windows. We will need this to land before we can do the follow-up PRs to handle the specific tests.
/cc. @gabriel-samfira