flightcontrol: add cachedgroup struct #5022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
flightcontrol-cachedgroup
branch
from
f15779d
to
9f66e2a
Compare
crazy-max
approved these changes
Jun 13, 2024
AkihiroSuda
reviewed
Jun 19, 2024
| return 0, errors.Errorf("some error") | ||
| }) | ||
|
|
||
| require.Error(t, err) |
There was a problem hiding this comment.
nit: this line does not seem needed, as it is covered by the ErrorContains below
AkihiroSuda
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an additional version of
flightcontrol.Groupthat caches previous results and returns earlier result if callback was already called for the same key.Also refactor
llb.Asyncanddockeruito use the new group. There are more cases that can be updated in follow-ups, for example in solver and puller, when implementing #4971 and rewriting https:/docker/buildx/blob/v0.15.0/build/driver.go#L50-L60 .Initially, this version was not used because without generics, it would have been quite hacky to do the
interace{}type casts everywhere.