Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint Rule for catching common secret related env/arg keys #5105

Merged
merged 7 commits into from
Jul 3, 2024
Merged

Lint Rule for catching common secret related env/arg keys #5105

merged 7 commits into from
Jul 3, 2024

Commits on Jul 2, 2024

  1. Add check rule that looks at keynames in arg and env and checks for c… 

    …ommon secret names

Signed-off-by: Talon Bowler <[email protected]>
    @daghack
    daghack committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    6e04857 View commit details
    Browse the repository at this point in the history

  2. Replace manual loop looking for secret related tokens with regex 

    Signed-off-by: Talon Bowler <[email protected]>
    @daghack
    daghack committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    20f4864 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Add documentation for SecretsUsedInArgOrEnv rule 

    Signed-off-by: Talon Bowler <[email protected]>
    @daghack
    daghack committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    14e2cab View commit details
    Browse the repository at this point in the history

  2. Update frontend/dockerfile/docs/rules/secrets-used-in-arg-or-env.md 

    Co-authored-by: David Karlsson <[email protected]>
Signed-off-by: Talon James Bowler <[email protected]>
    @daghack @dvdksn
    daghack and dvdksn authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    ac1c210 View commit details
    Browse the repository at this point in the history

  3. Update frontend/dockerfile/linter/ruleset.go 

    Co-authored-by: David Karlsson <[email protected]>
Signed-off-by: Talon James Bowler <[email protected]>
    @daghack @dvdksn
    daghack and dvdksn authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    fabe0dc View commit details
    Browse the repository at this point in the history

  4. update format string for SecretsUsedInArgOrEnv rule check 

    Signed-off-by: Talon Bowler <[email protected]>
    @daghack
    daghack committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    20224f5 View commit details
    Browse the repository at this point in the history

  5. Generate dockerfile documentation after updating SecretsUsedInArgOrEn… 

    …v rule description

Signed-off-by: Talon Bowler <[email protected]>
    @daghack
    daghack committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    390611d View commit details
    Browse the repository at this point in the history