adds InvalidDefaultArgInFrom lint check #5113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updates moved here @dvdksn 👍 |
daghack
force-pushed
the
invalid-default-arg-in-from
branch
2 times, most recently
from
05ec57f
to
57a3752
Compare
daghack
force-pushed
the
invalid-default-arg-in-from
branch
from
57a3752
to
69d6d4d
Compare
tonistiigi
approved these changes
Jul 2, 2024
| Name: "InvalidDefaultArgInFrom", | ||
| Description: "Using ARG with default value results in an empty or invalid base image name", | ||
| URL: "https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/", | ||
| Format: func(baseName string) string { |
There was a problem hiding this comment.
nit: it would be a bit more user-friendly if we would detect here if the base image is invalid or empty and show a message that is precise to the current condition. In case of "invalid image" we could also show what that invalid image name is.
dvdksn
reviewed
Jul 3, 2024
dvdksn
reviewed
Jul 3, 2024
dvdksn
reviewed
Jul 3, 2024
tonistiigi
approved these changes
Jul 3, 2024
|
@daghack Needs squash + rebase |
Signed-off-by: Talon Bowler <[email protected]>
daghack
force-pushed
the
invalid-default-arg-in-from
branch
from
18578ef
to
8bcc375
Compare
|
@tonistiigi As soon as tests pass, it should be good to go :) |
dvdksn
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks up the work left off here: #5102