Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codegen_rvalue_aggregate for tuples #2371

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

tautschnig
Copy link
Member

Description of changes:

We need to use the operands in the order prescribed by the layout, and cannot blindly trust the order provided as input in the Rvalue.

Resolved issues:

n/a

Related RFC:

n/a

Call-outs:

n/a

Testing:

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • n/a Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

We need to use the operands in the order prescribed by the layout, and
cannot blindly trust the order provided as input in the Rvalue.
@tautschnig tautschnig requested a review from a team as a code owner April 13, 2023 19:29
@tautschnig tautschnig changed the base branch from codegen-rvalue-tuples to main April 13, 2023 19:30
@tautschnig tautschnig changed the title Codegen rvalue tuples Fix codegen_rvalue_aggregate for tuples Apr 13, 2023
@tautschnig tautschnig merged commit a85f77c into model-checking:main Apr 13, 2023
@tautschnig tautschnig deleted the codegen-rvalue-tuples branch April 13, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants