feat: trigger name limit #1080
Merged
feat: trigger name limit #1080
+189
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almostinf
reviewed
Sep 5, 2024
almostinf
reviewed
Sep 5, 2024
Tetrergeru
reviewed
Sep 5, 2024
Tetrergeru
reviewed
Sep 5, 2024
kissken
reviewed
Sep 10, 2024
almostinf
previously approved these changes
Sep 10, 2024
kissken
reviewed
Sep 24, 2024
|
/build |
almostinf
previously approved these changes
Sep 27, 2024
almostinf
approved these changes
Oct 1, 2024
kissken
reviewed
Oct 2, 2024
| // LimitsConfig contains limits for some entities. | ||
| type LimitsConfig struct { | ||
| // Trigger contains limits for triggers. | ||
| Trigger TriggerLimits |
There was a problem hiding this comment.
а зачем такая вложенность? будут еще какие-то лимиты на триггер?
There was a problem hiding this comment.
Мы с Олегом эту штуку обсудили, решили оставить так. Вот аргументы за:
- вполне можно ожидать появления других лимитов как для триггера (например, на число тегов у триггера, на длину описания и т.п.), так и для других сущностей.
- ожидается, что эта структура будет создана и заполнена один раз, положена в контекст запросов, а потом она будет нужна для получения их неё значений
Tetrergeru
approved these changes
Oct 4, 2024
kissken
approved these changes
Oct 10, 2024
|
/build |
|
Build and push Docker images with tag: 2024-10-15.6541929 |
1 similar comment
|
Build and push Docker images with tag: 2024-10-15.6541929 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Before this PR there was no limit to trigger name. This can lead to problems with alert delivering.
This PR adds configurable limit for trigger name. It is highly recommended not to increase it.