Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Fields in Capture PHP Class Relative to JSON Documentation #708

Closed
pepeh opened this issue Mar 18, 2024 · 3 comments · Fixed by #709
Closed

Missing Fields in Capture PHP Class Relative to JSON Documentation #708

pepeh opened this issue Mar 18, 2024 · 3 comments · Fixed by #709

Comments

@pepeh
Copy link

pepeh commented Mar 18, 2024

Specifications

  • API Version: 2

Describe the issue

Upon integrating the Mollie API SDK for PHP, I noticed that there are discrepancies between the JSON response documented for captures and the Capture class in the PHP SDK. Specifically, there are fields present in the JSON response that are not available or represented in the Capture class, potentially leading to incomplete data handling or missing functionality for developers utilizing the SDK.

Identified Missing Fields

  • status: The JSON documentation includes a status field indicating the status of the capture (e.g., "succeeded"), but this field is not present in the Capture PHP class. This field is crucial for understanding the state of a capture.

  • metadata: The JSON example includes a metadata field that allows for the storage of additional information associated with the capture.

@maria-swierblewska
Copy link

Hi @sandervanhooft could you have a look into this?

@sandervanhooft
Copy link
Collaborator

Thanks for opening this ticket @pepeh !

I'll add the fields. Note that it will only help the IDE experience (autocomplete/hints) as Mollie's json response fields are assigned dynamically here.

@sandervanhooft
Copy link
Collaborator

Here it is!

https:/mollie/mollie-api-php/releases/tag/v2.66.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants