Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QC check for x-refs #7872

Closed
3 tasks
katiermullen opened this issue Jun 27, 2024 · 3 comments · Fixed by #8012
Closed
3 tasks

QC check for x-refs #7872

katiermullen opened this issue Jun 27, 2024 · 3 comments · Fixed by #8012
Assignees
Labels
QC tech issue requiring work from the technical team

Comments

@katiermullen
Copy link
Collaborator

katiermullen commented Jun 27, 2024

Could you please create a QC check (if it does not exist) to make sure that anytime there is a MONDO:preferredExternal that the x-ref also has the annotation MONDO:equivalentTo.

An example where I did not follow this rule is MONDO:1011429, the x-ref to OMIA:000605 should have the annotation MONDO:equivalentTo.

Note: the QC check should ensure that if an x-ref has a MONDO:relatedTo annotation it does not have a MONDO:preferredExternal annotation.

Finally, could you please add OMIA to the list of x-refs to QC: src/sparql/qc/general/qc-xref-without-source.sparql

Thank you!


Update from Trish:

  • Create QC check to make sure that anytime there is an xref with source annotation MONDO:preferredExternal that there is also an xref source annotation of MONDO:equivalentTo
  • Create QC check to make sure that anytime there is an xref with source annotation MONDO:relatedTo that it does not also have an xref source annotation of MONDO:preferredExternal
  • Add OMIA to the list of x-refs to QC: "src/sparql/qc/general/qc-xref-without-source.sparql"
@twhetzel twhetzel added the tech issue requiring work from the technical team label Jun 28, 2024
@matentzn
Copy link
Member

matentzn commented Jul 3, 2024

@sabrinatoro the only way for me to do this is if it ends up on a 1:1 meeting with us and I can do it then and there

@twhetzel
Copy link
Collaborator

Let me know if you want to re-assign. I updated the description a bit in case that makes it more clear what the checks should be.

@matentzn
Copy link
Member

Its done: #8012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QC tech issue requiring work from the technical team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants