feat(bsontype): move all _bsontypes to non-enumerable properties

mongodb · Aug 2, 2018 · 16f5bf6 · 16f5bf6
1 parent 545900d
commit 16f5bf6
Show file tree

Hide file tree

Showing 10 changed files with 13 additions and 21 deletions.
diff --git a/lib/binary.js b/lib/binary.js
@@ -30,8 +30,6 @@ class Binary {
  throw new Error('only String, Buffer, Uint8Array or Array accepted');
  }
 
- this._bsontype = 'Binary';
-
  if (buffer instanceof Number) {
  this.sub_type = buffer;
  this.position = 0;
@@ -375,7 +373,5 @@ Binary.SUBTYPE_MD5 = 5;
  **/
 Binary.SUBTYPE_USER_DEFINED = 128;
 
-/**
- * Expose.
- */
+Object.defineProperty(Binary.prototype, '_bsontype', { value: 'Binary' });
 module.exports = Binary;
diff --git a/lib/code.js b/lib/code.js
@@ -12,7 +12,6 @@ class Code {
  * @return {Code}
  */
  constructor(code, scope) {
- this._bsontype = 'Code';
  this.code = code;
  this.scope = scope;
  }
@@ -25,4 +24,5 @@ class Code {
  }
 }
 
+Object.defineProperty(Code.prototype, '_bsontype', { value: 'Code' });
 module.exports = Code;
diff --git a/lib/db_ref.js b/lib/db_ref.js
@@ -1,4 +1,5 @@
 'use strict';
+
 /**
  * A class representation of the BSON DBRef type.
  */
@@ -19,7 +20,6 @@ class DBRef {
  collection = parts.shift();
  }
 
- this._bsontype = 'DBRef';
  this.collection = collection;
  this.oid = oid;
  this.db = db;
@@ -44,4 +44,5 @@ class DBRef {
  }
 }
 
+Object.defineProperty(DBRef.prototype, '_bsontype', { value: 'DBRef' });
 module.exports = DBRef;
diff --git a/lib/double.js b/lib/double.js
@@ -10,7 +10,6 @@ class Double {
  * @return {Double}
  */
  constructor(value) {
- this._bsontype = 'Double';
  this.value = value;
  }
 
@@ -32,4 +31,5 @@ class Double {
  }
 }
 
+Object.defineProperty(Double.prototype, '_bsontype', { value: 'Double' });
 module.exports = Double;
diff --git a/lib/int_32.js b/lib/int_32.js
@@ -10,7 +10,6 @@ class Int32 {
  * @return {Int32}
  */
  constructor(value) {
- this._bsontype = 'Int32';
  this.value = value;
  }
 
@@ -32,4 +31,5 @@ class Int32 {
  }
 }
 
+Object.defineProperty(Int32.prototype, '_bsontype', { value: 'Int32' });
 module.exports = Int32;
diff --git a/lib/max_key.js b/lib/max_key.js
@@ -8,9 +8,8 @@ class MaxKey {
  *
  * @return {MaxKey} A MaxKey instance
  */
- constructor() {
- this._bsontype = 'MaxKey';
- }
+ constructor() {}
 }
 
+Object.defineProperty(MaxKey.prototype, '_bsontype', { value: 'MaxKey' });
 module.exports = MaxKey;
diff --git a/lib/min_key.js b/lib/min_key.js
@@ -8,9 +8,8 @@ class MinKey {
  *
  * @return {MinKey} A MinKey instance
  */
- constructor() {
- this._bsontype = 'MinKey';
- }
+ constructor() {}
 }
 
+Object.defineProperty(MinKey.prototype, '_bsontype', { value: 'MinKey' });
 module.exports = MinKey;
diff --git a/lib/objectid.js b/lib/objectid.js
@@ -53,7 +53,6 @@ class ObjectID {
  constructor(id) {
  // Duck-typing to support ObjectId from different npm packages
  if (id instanceof ObjectID) return id;
- this._bsontype = 'ObjectID';
 
  // The most common usecase (blank id, new objectId instance)
  if (id == null || typeof id === 'number') {
@@ -381,7 +380,5 @@ ObjectID.prototype.inspect = ObjectID.prototype.toString;
  */
 ObjectID.index = ~~(Math.random() * 0xffffff);
 
-/**
- * Expose.
- */
+Object.defineProperty(ObjectID.prototype, '_bsontype', { value: 'ObjectID' });
 module.exports = ObjectID;
diff --git a/lib/regexp.js b/lib/regexp.js
@@ -19,7 +19,6 @@ class BSONRegExp {
  */
  constructor(pattern, options) {
  // Execute
- this._bsontype = 'BSONRegExp';
  this.pattern = pattern || '';
  this.options = options ? alphabetize(options) : '';
 
@@ -41,4 +40,5 @@ class BSONRegExp {
  }
 }
 
+Object.defineProperty(BSONRegExp.prototype, '_bsontype', { value: 'BSONRegExp' });
 module.exports = BSONRegExp;
diff --git a/lib/symbol.js b/lib/symbol.js
@@ -9,7 +9,6 @@ class Symbol {
  * @param {string} value the string representing the symbol.
  */
  constructor(value) {
- this._bsontype = 'Symbol';
  this.value = value;
  }
 
@@ -45,4 +44,5 @@ class Symbol {
  }
 }
 
+Object.defineProperty(Symbol.prototype, '_bsontype', { value: 'Symbol' });
 module.exports = Symbol;