feat(NODE-3034): deprecate number as an input to ObjectId constructor #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
added
the
Primary Review
nbbeeken
requested changes
Jan 25, 2024
nbbeeken
approved these changes
Jan 26, 2024
This was referenced May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecate
numberas an input toObjectIdconstructor.What is changing?
Create separate overloads for each input type of the ObjectID constructor and deprecate one that accepts a numeric input value.
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-3034
Release Highlight
A number as an input to the
ObjectIdconstructor is deprecatedInstead, use
static createFromTime()to set a numeric value for the new ObjectId.Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript