feat(NODE-6087): add Int32.fromString method #670
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add static
Int32.fromString()
method.What is changing?
Is there new documentation needed for these changes?
Yes, there are new API docs.
What is the motivation for this change?
NODE-3660 user ticket, our validation in the Int32 is lacking. In V7, we will add
Int32.fromString(value)
validation call into theInt32
constructor'sstring
case.Release Highlight
Add static
Int32.fromString
methodThis method attempts to create an
Int32
type from string, and will throw aBSONError
on any string input that is not representable as anInt32
.Notably, this method will also throw on the following string formats:
Strings with leading zeros, however, are allowed
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript