fix(NODE-3376): use standard JS methods for copying Buffers #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use standard JS methods for copying Buffers, because unlike the `buffer` module polyfill, these have working typechecking - Add tests that ensure that for all BSON distributions and all legacy packages, their serialization is cross-compatible (modulo NODE-2848, which would require updates to either the `buffer` poyfill or the legacy 1.x bson versions).
addaleax
commented
Jun 25, 2021
dariakp
added
the
Primary Review
nbbeeken
approved these changes
Jun 25, 2021
nbbeeken
added
Team Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
buffermodule polyfill, these have working typecheckinglegacy packages, their serialization is cross-compatible
(modulo NODE-2848, which would require updates to either the
bufferpoyfill or the legacy 1.x bson versions).