Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GODRIVER-3340 Bump github.com/klauspost/compress from 1.13.6 to 1.17.2 [release/1.17] #1868

Open
wants to merge 1 commit into
base: release/1.17
Choose a base branch
from
Open

GODRIVER-3340 Bump github.com/klauspost/compress from 1.13.6 to 1.17.2 [release/1.17] #1868

wants to merge 1 commit into from

Conversation

matthewdale
Copy link
Collaborator

GODRIVER-3340

Summary

Bump github.com/klauspost/compress from 1.13.6 to 1.17.2

Background & Motivation

Resolves a goroutine/memory leak when using zstd compression.

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added dependencies Pull requests that update a dependency file priority-3-low Low Priority PR for Review labels Oct 16, 2024
@mongodb-drivers-pr-bot mongodb-drivers-pr-bot
Copy link
Contributor

API Change Report

No changes found!

@blink1073
Copy link
Member

Oh, buildcheck failed on 1.18:

[2024/10/15 22:26:57.984] # github.com/klauspost/compress/zstd
[2024/10/15 22:26:57.984] vendor/github.com/klauspost/compress/zstd/dict.go:479:32: binary.LittleEndian.AppendUint32 undefined (type binary.littleEndian has no field or method AppendUint32)
[2024/10/15 22:26:57.984] vendor/github.com/klauspost/compress/zstd/dict.go:490:32: binary.LittleEndian.AppendUint32 undefined (type binary.littleEndian has no field or method AppendUint32)
[2024/10/15 22:26:57.984] vendor/github.com/klauspost/compress/zstd/dict.go:491:32: binary.LittleEndian.AppendUint32 undefined (type binary.littleEndian has no field or method AppendUint32)
[2024/10/15 22:26:57.984] vendor/github.com/klauspost/compress/zstd/dict.go:492:32: binary.LittleEndian.AppendUint32 undefined (type binary.littleEndian has no field or method AppendUint32)
[2024/10/15 22:26:59.113] etc/compile_check.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file priority-3-low Low Priority PR for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewdale @blink1073