Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix array shape for Collection::listSearchIndex($options) #1480

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Fix array shape for Collection::listSearchIndex($options) #1480

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
379e406
Fix array shape for Collection::listSearchIndex $options
GromNaN Oct 14, 2024
d8189f1
Remove array shape, not supported by phpcs
GromNaN Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,7 +896,7 @@
* Returns information for all Atlas Search indexes for the collection.
* Only available when used against a 7.0+ Atlas cluster.
*
* @param array{name?: string} $options Command options
* @param array{name?: string, ...} $options Command options
* @return Countable&Iterator
* @throws InvalidArgumentException for parameter/option parsing errors
* @throws DriverRuntimeException for other driver errors (e.g. connection errors)
Expand Down Expand Up @@ -925,7 +925,7 @@
* @throws DriverRuntimeException for other driver errors (e.g. connection errors)
* @throws UnexpectedValueException if the command response was malformed
*/
public function mapReduce(JavascriptInterface $map, JavascriptInterface $reduce, $out, array $options = [])

Check failure on line 928 in src/Collection.php

View workflow job for this annotation

GitHub Actions / phpcs 

Missing parameter name
{
$hasOutputCollection = ! is_mapreduce_output_inline($out);

Expand Down
2 changes: 1 addition & 1 deletion src/Operation/ListSearchIndexes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
*
* @param string $databaseName Database name
* @param string $collectionName Collection name
* @param array{name?: string} $options Command options
* @param array{name?: string, ...} $options Command options

Check failure on line 51 in src/Operation/ListSearchIndexes.php

View workflow job for this annotation

GitHub Actions / phpcs 

Missing parameter name
*/
public function __construct(string $databaseName, string $collectionName, array $options = [])
{
Expand Down
Loading