Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-6241): allow Binary as local KMS provider key #4160

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

addaleax
Copy link
Contributor

@addaleax addaleax commented Jun 25, 2024

This aligns the types with actual behavior as well as the shell's expected set of supported types.

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Accurate TS

Release Highlight

The LocalKMSProviderConfiguration's key property accepts Binary

A local KMS provider at runtime accepted a BSON Binary instance but the Typescript inaccurately only permitted Buffer and string.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

This aligns the types with actual behavior as well as the shell's
expected set of supported types.
@nbbeeken nbbeeken self-assigned this Jun 25, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 25, 2024
@addaleax addaleax requested a review from nbbeeken June 25, 2024 22:16
@nbbeeken nbbeeken merged commit fb724eb into mongodb:main Jun 26, 2024
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants