Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --noIndexRestore to mongorestore options #2

Merged
merged 2 commits into from
Apr 1, 2013

Conversation

fancyremarker
Copy link
Contributor

This raises an interesting issue, so please feel free to reject; --noIndexRestore is only supported in mongorestore version 2.2.0 and higher. Adding --noIndexRestore to the arguments of an older version of mongorestore will result in an error.

Perhaps mongoid-shell could add even more value by providing tool version portability for arguments like this? So if :noIndexRestore was included among the options to Mongoid::Shell::Commands::Mongorestore.new, the gem could make a decision about whether to actually include it in the command string, based on the version of the underlying tool?

@dblock
Copy link
Collaborator

dblock commented Apr 1, 2013

I think it's totally fine, the job of this gem is to make shell command lines, then the command fails if it fails. Can you please update CHANGELOG too? Thx.

@fancyremarker
Copy link
Contributor Author

Updated CHANGELOG, and also README.

@dblock dblock merged commit cf133ec into mongoid:master Apr 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants