Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Mongoid::Config#models in Rake task, resolves #247 #255

Merged
merged 2 commits into from
Aug 17, 2018
Merged

Conversation

kailan
Copy link
Collaborator

@kailan kailan commented Aug 17, 2018

No description provided.

@mongoid-bot
Copy link

mongoid-bot commented Aug 17, 2018

1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by 🚫 danger

@kailan kailan merged commit f732b7a into master Aug 17, 2018
@kailan kailan deleted the model-lookup branch August 17, 2018 17:49
@@ -1,6 +1,7 @@
## 6.0.1 (Next)

* Your contribution here.
* [#255](https:/mongoid/mongoid-slug/pull/255): Use mongoid::config#models in rake task, resolves #247 - [@kailan](https:/kailan).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally a prettier, clickable syntax for this is

[#255](https:/mongoid/mongoid-slug/pull/255), [#247](https:/mongoid/mongoid-slug/pull/247): Use `mongoid::config#models` in rake task - [@kailan](https:/kailan).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants