Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt xcm-utils to XCM V3 #2304

Merged
merged 16 commits into from
May 23, 2023
Merged

Adapt xcm-utils to XCM V3 #2304

merged 16 commits into from
May 23, 2023

Conversation

Agusrodri
Copy link
Contributor

What does it do?

This PR performs the adaptation of xcm-utils (used in typescript tests) to work well with XCM V3, adding the new instructions and modifying the previous necessary ones for them to behave properly with V3.

@Agusrodri Agusrodri added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) not-breaking Does not need to be mentioned in breaking changes labels May 16, 2023
@Agusrodri Agusrodri requested a review from timbrinded May 16, 2023 13:10
@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2023

Coverage generated "Mon May 22 22:36:20 UTC 2023":
https://s3.amazonaws.com/moonbeam-coverage/pulls/2304/html/index.html

Master coverage: 72.45%
Pull coverage: 72.46%

Copy link
Contributor

@timbrinded timbrinded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great coverage, just added some comments on making the helpers more helpful, and some Polkadot.js best practises. A lot of the comments are duplicates but that's just to help the refactoring

tests/util/xcm.ts Outdated Show resolved Hide resolved
tests/util/xcm.ts Outdated Show resolved Hide resolved
tests/util/xcm.ts Outdated Show resolved Hide resolved
tests/util/xcm.ts Outdated Show resolved Hide resolved
tests/util/xcm.ts Outdated Show resolved Hide resolved
tests/tests/test-xcm/test-xcmv3-new-instructions.ts Outdated Show resolved Hide resolved
tests/tests/test-xcm/test-xcmv3-new-instructions.ts Outdated Show resolved Hide resolved
tests/tests/test-xcm/test-xcmv3-new-instructions.ts Outdated Show resolved Hide resolved
tests/tests/test-xcm/test-xcmv3-new-instructions.ts Outdated Show resolved Hide resolved
tests/tests/test-xcm/test-xcmv3-new-instructions.ts Outdated Show resolved Hide resolved
@Agusrodri Agusrodri requested a review from timbrinded May 19, 2023 14:55
tests/util/xcm.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@librelois librelois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please tests the existing V2 instructions in V3, especially DepositAsset

@Agusrodri Agusrodri requested a review from librelois May 22, 2023 21:51
@Agusrodri Agusrodri merged commit 2525898 into master May 23, 2023
@Agusrodri Agusrodri deleted the timbo-xcmv3-tests branch May 23, 2023 16:00
timbrinded added a commit that referenced this pull request Jun 2, 2023
* first attempt

* progress

* added new instructions to fragment

* add more instructions (draft)

* add remaining xcmv3 instructions

* split files and fmt

* delete files

* refactor of some files

* add comments

* refactor code and parameterize with new interfaces

* add default case in expect

* remove unused imports

* add tests for existing v2 instructions

---------

Co-authored-by: timbrinded <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants