This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
Stop providing author inherent data #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
suggested changes
Dec 8, 2021
Co-authored-by: Éloïs <[email protected]>
librelois
approved these changes
Dec 13, 2021
|
@librelois @nbaztec I believe this one is ready. Is there anything blocking it that you know of? |
|
@JoshOrndorff yes we can merge this PR now, we just forgot because we were constantly busy with other things! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE until after nimbus 0.9 has been tagged.
This PR is a followup to #15. It simplifies the client-side code by no longer providing any real inherent data. Previously it provided the author id, but since #15, the data supplied there has not been used, and the pre-runtime digest is used instead.