Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lark-parser with lark in the environment files. #575

Merged
merged 6 commits into from
Aug 19, 2024

Conversation

chrisjonesBSU
Copy link
Contributor

This was originally added as part of #574, but that PR might have to sit open for a while until we want to drop 3.9 and support 3.13, so I figured I'd add the lark related changes to a separate PR. This should get rid of one deprecation warning, plus makes sure we're using updated versions of lark.

lark-parser was the old conda environment name for the lark package, it's now just lark, but it's the same package.

I'll open an issue in the foyer feedstock so we remember to change it there as well.

@chrisjonesBSU chrisjonesBSU changed the title Replace lark-parser with lark in the environment files files Replace lark-parser with lark in the environment files. Jul 18, 2024
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.01%. Comparing base (d2ad660) to head (77ca8c0).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #575      +/-   ##
==========================================
+ Coverage   61.90%   62.01%   +0.11%     
==========================================
  Files          16       16              
  Lines        1667     1664       -3     
==========================================
  Hits         1032     1032              
+ Misses        635      632       -3     

@CalCraven CalCraven merged commit 30c6d3d into mosdef-hub:main Aug 19, 2024
16 checks passed
@chrisjonesBSU chrisjonesBSU deleted the use-lark branch August 20, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants