Skip to content

Commit

Permalink
Replaced rimraf with fs.remove (#291)
Browse files Browse the repository at this point in the history
* Replace rimraf with fs.removeSync

It seems to be using rimraf in fs-extra

* Remove unnecessary rimraf
  • Loading branch information
abetomo authored and DeviaVir committed May 22, 2017
1 parent e4506bb commit 2254ae1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 70 deletions.
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
"dotenv": "^0.4.0",
"fs-extra": "^0.30.0",
"minimatch": "^3.0.3",
"node-zip": "^1.1.0",
"rimraf": "^2.2.8"
"node-zip": "^1.1.0"
}
}
5 changes: 2 additions & 3 deletions test/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ var fs = require('fs-extra');
var Hoek = require('hoek');
var lambda = require(path.join(__dirname, '..', 'lib', 'main'));
var zip = require('node-zip');
var rimraf = require('rimraf');

var assert = chai.assert;

Expand Down Expand Up @@ -289,7 +288,7 @@ describe('lib/main', function () {
it(funcName + ' should not include package.json when --prebuiltDirectory is set', function (done) {
var buildDir = '.build_' + Date.now();
after(function() {
rimraf.sync(buildDir, fs);
fs.removeSync(buildDir);
});

fs.mkdirSync(buildDir);
Expand Down Expand Up @@ -459,7 +458,7 @@ describe('lib/main', function () {
_timeout({ this: this, sec: 30 }); // give it time to zip
var buildDir = '.build_' + Date.now();
after(function() {
rimraf.sync(buildDir, fs);
fs.removeSync(buildDir);
});

fs.mkdirSync(buildDir);
Expand Down
68 changes: 3 additions & 65 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,7 @@ aws-sdk-mock@^1.6.1:
sinon "^1.17.3"
traverse "^0.6.6"

aws-sdk@^2.3.0:
version "2.7.13"
resolved "https://registry.yarnpkg.com/aws-sdk/-/aws-sdk-2.7.13.tgz#bb2384b6b49d45d0bcc6ff1701aff32db042a57c"
dependencies:
buffer "4.9.1"
crypto-browserify "1.0.9"
jmespath "0.15.0"
querystring "0.2.0"
sax "1.1.5"
url "0.10.3"
uuid "3.0.0"
xml2js "0.4.15"
xmlbuilder "2.6.2"

aws-sdk@^2.49.0:
aws-sdk@^2.3.0, aws-sdk@^2.49.0:
version "2.49.0"
resolved "https://registry.yarnpkg.com/aws-sdk/-/aws-sdk-2.49.0.tgz#e340451b38b9772b2320da64a2cc272410667c69"
dependencies:
Expand Down Expand Up @@ -65,14 +51,6 @@ [email protected]:
version "1.3.0"
resolved "https://registry.yarnpkg.com/browser-stdout/-/browser-stdout-1.3.0.tgz#f351d32969d32fa5d7a5567154263d928ae3bd1f"

[email protected]:
version "4.9.1"
resolved "https://registry.yarnpkg.com/buffer/-/buffer-4.9.1.tgz#6d1bb601b07a4efced97094132093027c95bc298"
dependencies:
base64-js "^1.0.2"
ieee754 "^1.1.4"
isarray "^1.0.0"

[email protected]:
version "5.0.6"
resolved "https://registry.yarnpkg.com/buffer/-/buffer-5.0.6.tgz#2ea669f7eec0b6eda05b08f8b5ff661b28573588"
Expand Down Expand Up @@ -145,7 +123,7 @@ fs.realpath@^1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/fs.realpath/-/fs.realpath-1.0.0.tgz#1504ad2523158caa40db4a2787cb01411994ea4f"

[email protected]:
[email protected], glob@^7.0.5:
version "7.0.5"
resolved "https://registry.yarnpkg.com/glob/-/glob-7.0.5.tgz#b4202a69099bbb4d292a7c1b95b6682b67ebdc95"
dependencies:
Expand All @@ -156,17 +134,6 @@ [email protected]:
once "^1.3.0"
path-is-absolute "^1.0.0"

glob@^7.0.5:
version "7.1.1"
resolved "https://registry.yarnpkg.com/glob/-/glob-7.1.1.tgz#805211df04faaf1c63a3600306cdf5ade50b2ec8"
dependencies:
fs.realpath "^1.0.0"
inflight "^1.0.4"
inherits "2"
minimatch "^3.0.2"
once "^1.3.0"
path-is-absolute "^1.0.0"

graceful-fs@^4.1.2, graceful-fs@^4.1.6, graceful-fs@^4.1.9:
version "4.1.11"
resolved "https://registry.yarnpkg.com/graceful-fs/-/graceful-fs-4.1.11.tgz#0e8bdfe4d1ddb8854d64e04ea7c00e2a026e5658"
Expand Down Expand Up @@ -206,10 +173,6 @@ [email protected]:
version "2.0.1"
resolved "https://registry.yarnpkg.com/inherits/-/inherits-2.0.1.tgz#b17d08d326b4423e568eff719f91b0b1cbdf69f1"

isarray@^1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/isarray/-/isarray-1.0.0.tgz#bb935d48582cba168c06834957a54a3e07124f11"

[email protected]:
version "0.15.0"
resolved "https://registry.yarnpkg.com/jmespath/-/jmespath-0.15.0.tgz#a3f222a9aae9f966f5d27c796510e28091764217"
Expand Down Expand Up @@ -287,10 +250,6 @@ lodash@^4.0.0:
version "4.17.4"
resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.4.tgz#78203a4d1c328ae1d86dca6460e369b57f4055ae"

lodash@~3.5.0:
version "3.5.0"
resolved "https://registry.yarnpkg.com/lodash/-/lodash-3.5.0.tgz#19bb3f4d51278f0b8c818ed145c74ecf9fe40e6d"

[email protected]:
version "1.3.2"
resolved "https://registry.yarnpkg.com/lolex/-/lolex-1.3.2.tgz#7c3da62ffcb30f0f5a80a2566ca24e45d8a01f31"
Expand Down Expand Up @@ -369,11 +328,7 @@ [email protected], samsam@~1.1:
version "1.1.2"
resolved "https://registry.yarnpkg.com/samsam/-/samsam-1.1.2.tgz#bec11fdc83a9fda063401210e40176c3024d1567"

[email protected], sax@>=0.6.0:
version "1.1.5"
resolved "https://registry.yarnpkg.com/sax/-/sax-1.1.5.tgz#1da50a8d00cdecd59405659f5ff85349fe773743"

[email protected]:
[email protected], sax@>=0.6.0:
version "1.2.1"
resolved "https://registry.yarnpkg.com/sax/-/sax-1.2.1.tgz#7b8e656190b228e81a66aea748480d828cd2d37a"

Expand Down Expand Up @@ -451,10 +406,6 @@ [email protected]:
dependencies:
inherits "2.0.1"

[email protected]:
version "3.0.0"
resolved "https://registry.yarnpkg.com/uuid/-/uuid-3.0.0.tgz#6728fc0459c450d796a99c31837569bdf672d728"

[email protected]:
version "3.0.1"
resolved "https://registry.yarnpkg.com/uuid/-/uuid-3.0.1.tgz#6544bba2dfda8c1cf17e629a3a305e2bb1fee6c1"
Expand All @@ -463,26 +414,13 @@ wrappy@1:
version "1.0.2"
resolved "https://registry.yarnpkg.com/wrappy/-/wrappy-1.0.2.tgz#b5243d8f3ec1aa35f1364605bc0d1036e30ab69f"

[email protected]:
version "0.4.15"
resolved "https://registry.yarnpkg.com/xml2js/-/xml2js-0.4.15.tgz#95cd03ff2dd144ec28bc6273bf2b2890c581ad0c"
dependencies:
sax ">=0.6.0"
xmlbuilder ">=2.4.6"

[email protected]:
version "0.4.17"
resolved "https://registry.yarnpkg.com/xml2js/-/xml2js-0.4.17.tgz#17be93eaae3f3b779359c795b419705a8817e868"
dependencies:
sax ">=0.6.0"
xmlbuilder "^4.1.0"

[email protected], xmlbuilder@>=2.4.6:
version "2.6.2"
resolved "https://registry.yarnpkg.com/xmlbuilder/-/xmlbuilder-2.6.2.tgz#f916f6d10d45dc171b1be2e6e673fb6e0cc35d0a"
dependencies:
lodash "~3.5.0"

[email protected], xmlbuilder@^4.1.0:
version "4.2.1"
resolved "https://registry.yarnpkg.com/xmlbuilder/-/xmlbuilder-4.2.1.tgz#aa58a3041a066f90eaa16c2f5389ff19f3f461a5"
Expand Down

0 comments on commit 2254ae1

Please sign in to comment.