Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--excludeGlobs takes a space-separated list #111

Merged
merged 1 commit into from
Jun 16, 2016
Merged

--excludeGlobs takes a space-separated list #111

merged 1 commit into from
Jun 16, 2016

Conversation

rkuzsma
Copy link
Contributor

@rkuzsma rkuzsma commented Jun 4, 2016

-x or --excludeGlobs appears to take a space-separated list of files/types, not a comma-separated list.

-x or --excludeGlobs appears to take a space-separated list of files/types, not a comma-separated list.
@DeviaVir
Copy link
Collaborator

DeviaVir commented Jun 5, 2016

Hi @rkuzsma, thanks for checking this out! It might be nicer to solve https:/motdotla/node-lambda/blob/master/lib/main.js#L144 instead?

@DeviaVir
Copy link
Collaborator

+1; actually a space separated list might look nicer overall, rolling with it

@DeviaVir DeviaVir merged commit 7cf9b3a into motdotla:master Jun 16, 2016
@rkuzsma
Copy link
Contributor Author

rkuzsma commented Jun 17, 2016

Thanks for the merge! Alternatively, I could update main.js to use node-glob to support **/*.js style syntax, which is super flexible, but it would break backwards compatibility, and potentially overkill.

@DeviaVir DeviaVir mentioned this pull request Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants