Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to be the same specification as --exclude of rsync command (about function which is an alternative to rsync command) #244

Merged
merged 4 commits into from
Apr 25, 2017

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Apr 25, 2017

(After checking the operation a bit more in my environment, I will replace it with the _fileCopy function from the _rsync function.)

In order to make it easy to understand where test failed, I changed the way I write the test. (The meaning of the test has not changed.)

The rsync command `--exclude` can remove` lib/main.js` in `*main*`.
_fileCopy did not satisfy the specification, so I modified it
The rsync command `--exclude` can remove` lib/main.js` in `*main*`.
- To make it easy to understand what file failed
- Using `assert.include`
@DeviaVir DeviaVir self-requested a review April 25, 2017 14:38
Copy link
Collaborator

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious how this plays out, please continue 👍

@DeviaVir DeviaVir merged commit a57f421 into motdotla:master Apr 25, 2017
@abetomo abetomo deleted the fix_file_copy_exclude branch May 2, 2017 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants