Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to using path object #249

Merged
merged 6 commits into from
Apr 26, 2017
Merged

Fix to using path object #249

merged 6 commits into from
Apr 26, 2017

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Apr 26, 2017

By creating path of the file with path.join, it will also work on Windows.

DeviaVir
DeviaVir approved these changes Apr 26, 2017
View reviewed changes
Copy link
Collaborator

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, keep up the great work @abetomo! 👍

@DeviaVir DeviaVir merged commit dba654e into motdotla:master Apr 26, 2017
@abetomo abetomo deleted the fix_using_path branch May 2, 2017 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeviaVir DeviaVir DeviaVir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abetomo @DeviaVir