Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring lib/main.js #398

Merged
merged 4 commits into from
Dec 14, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions lib/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -678,9 +678,7 @@ so you can easily test run multiple events.
}
return Promise.resolve()
})).then((data) => {
return Promise.resolve(data)
}).catch((err) => {
return Promise.reject(err)
return data
})
}

Expand All @@ -701,9 +699,7 @@ so you can easily test run multiple events.
// Since `scheduleEvents.add(params)` returns only `{}` if it succeeds
// it is not very meaningful.
// Therefore, return the params used for execution
return Promise.resolve(paramsList)
}).catch((err) => {
return Promise.reject(err)
return paramsList
})
}

Expand Down Expand Up @@ -773,7 +769,7 @@ so you can easily test run multiple events.
console.log('=> Reading event source file to memory')
const eventSourceList = this._eventSourceList(program)

return new Promise((resolve, reject) => {
return Promise.resolve().then(() => {
console.log('=> Uploading zip file to AWS Lambda ' + region + ' with parameters:')
console.log(params)

Expand Down Expand Up @@ -846,10 +842,8 @@ so you can easily test run multiple events.
params.FunctionName
)
]).then((results) => {
resolve(results)
return results
})
}).catch((err) => {
reject(err)
})
}).catch(() => {
// Function does not exist
Expand Down Expand Up @@ -880,10 +874,8 @@ so you can easily test run multiple events.
params.FunctionName
)
]).then((results) => {
resolve(results)
return results
})
}).catch((err) => {
reject(err)
})
})
})
Expand Down