Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary try-cache #401

Merged
merged 1 commit into from
Dec 18, 2017
Merged

Remove unnecessary try-cache #401

merged 1 commit into from
Dec 18, 2017

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Dec 18, 2017

Because it is meaningless to just throw err.

@abetomo
Remove unnecessary try-cache
91b48d0 
Because it is meaningless to just throw err.
DeviaVir
DeviaVir approved these changes Dec 18, 2017
View reviewed changes
Copy link
Collaborator

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice cleanup so far!

@DeviaVir DeviaVir merged commit 37e771e into motdotla:master Dec 18, 2017
@abetomo abetomo deleted the refactor_lib_main.js branch December 18, 2017 09:59
@DeviaVir DeviaVir mentioned this pull request Jan 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeviaVir DeviaVir DeviaVir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abetomo @DeviaVir