Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support npm7 #550

Merged
merged 3 commits into from
Feb 5, 2021
Merged

Support npm7 #550

merged 3 commits into from
Feb 5, 2021

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Feb 4, 2021

No description provided.

@abetomo
fix: _codeDirectory()
7fba968 
If tmpdir is symbolic link and npm>=7, `this._npmInstall()` may not work properly.
@abetomo
test: fix the test because the 'install' specification has changed in…
c5e759c 
… npm7
@abetomo
chore: add comment
8d282d4
@abetomo abetomo mentioned this pull request Feb 4, 2021
Merged
DeviaVir
DeviaVir approved these changes Feb 5, 2021
View reviewed changes
Copy link
Collaborator

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DeviaVir DeviaVir merged commit cf80c6a into motdotla:master Feb 5, 2021
@abetomo abetomo deleted the feature/support_npm7 branch February 5, 2021 08:41
@abetomo
Copy link
Contributor Author

abetomo commented Feb 5, 2021

Thanks for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeviaVir DeviaVir DeviaVir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abetomo @DeviaVir