Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove BUILD from the exclusion list #607

Merged
merged 1 commit into from
May 18, 2022
Merged

feat: remove BUILD from the exclusion list #607

merged 1 commit into from
May 18, 2022

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented May 18, 2022

BREAKING CHANGE

It looks like build may not have to be on the default exclusion list.
What do you think?

fix #606

DeviaVir
DeviaVir approved these changes May 18, 2022
View reviewed changes
Copy link
Collaborator

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, makes sense to be more explicit which one we want to exclude.

@DeviaVir DeviaVir merged commit 11474bc into motdotla:master May 18, 2022
@abetomo abetomo deleted the feature/remove_build_from_the_exclusion_list branch May 18, 2022 23:34
@abetomo
Copy link
Contributor Author

abetomo commented May 18, 2022

Thank you for all your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeviaVir DeviaVir DeviaVir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_fileCopy excluding all folders named 'build' from archive
2 participants
@abetomo @DeviaVir