Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Motion planning api demo #273

Merged
merged 3 commits into from
Jan 8, 2019
Merged

Motion planning api demo #273

merged 3 commits into from
Jan 8, 2019

Conversation

mlautman
Copy link
Contributor

This addresses #256

It also adds some nicer visualizations and fixes miscellaneous bugs.

v4hn
v4hn previously requested changes Dec 25, 2018
View reviewed changes
Copy link
Contributor

@v4hn v4hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

doc/motion_planning_api/motion_planning_api_tutorial.rst Show resolved Hide resolved
doc/motion_planning_api/src/motion_planning_api_tutorial.cpp Show resolved Hide resolved
@mlautman
Copy link
Contributor Author

mlautman commented Jan 2, 2019

@v4hn @davetcoleman I'm going to merge this tomorrow if there is no additional feedback

@mlautman mlautman mentioned this pull request Jan 2, 2019
Closed
@mlautman mlautman dismissed v4hn’s stale review January 4, 2019 22:57

All feedback addressed

@mlautman mlautman merged commit 89f3257 into moveit:melodic-devel Jan 8, 2019
rconnorlawson pushed a commit to rconnorlawson/moveit_tutorials that referenced this pull request Apr 30, 2019
@mlautman @rconnorlawson
Cherry-pick 89f3257 to kinetic-devel branch (moveit#273)
dae9017 
Original commit message:

Motion planning api demo (moveit#273)

* fixing motion planning api demo
@rconnorlawson rconnorlawson mentioned this pull request Apr 30, 2019
Merged
2 tasks
mlautman pushed a commit that referenced this pull request May 29, 2019
@rconnorlawson @mlautman
Cherry-pick 89f3257 to kinetic-devel branch (#273) (#320)
6633525 
Original commit message:

Motion planning api demo (#273)

* fixing motion planning api demo
@hygxy
Copy link

hygxy commented May 30, 2019 •
edited
Loading

Hey, I've pulled the latest "cherry-picked" commit and rebuilt my catkin workspace and I am referencing the Kinect version of the corresponding tutorial about motion planning api(http://docs.ros.org/kinetic/api/moveit_tutorials/html/doc/motion_planning_api/motion_planning_api_tutorial.html), which is just one line:
roslaunch moveit_tutorials motion_planning_api_tutorial.launch
I then got the error message:
Robot model parameter not found! Did you remap 'robot_description'?
I then switched to the melodic version of the corresponding tutorial(https://ros-planning.github.io/moveit_tutorials/doc/motion_planning_api/motion_planning_api_tutorial.html), which is two lines:
roslaunch panda_moveit_config demo.launch
roslaunch moveit_tutorials motion_planning_api_tutorial.launch
But then I got the message "Waiting for complete state from topic" continuously in the second shell and there is no message like " press the Next button in the RvizVisualToolsGui..." as the case before cherry-pick, Could you help me with this situation?

This was referenced Aug 28, 2019
Closed
Merged
@basalp basalp mentioned this pull request Feb 4, 2021
Open
@Gaurav37 Gaurav37 mentioned this pull request Nov 29, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davetcoleman davetcoleman davetcoleman approved these changes

@v4hn v4hn v4hn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mlautman @hygxy @davetcoleman @v4hn