Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fully extended pose: 'extended' #39

Merged
merged 2 commits into from
Aug 8, 2019

Conversation

henningkayser
Copy link
Member

panda_home
This adds a simple named pose 'home' where the group panda_arm_hand is fully extended.

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you need this pose for the tutorials.
In general, I would argue that named poses (particularly home) are highly subjective to a specific user and task.

@henningkayser
Copy link
Member Author

@rhaschke I agree, how about "extended""?

@henningkayser henningkayser changed the title Add fully extended pose: 'home' Add fully extended pose: 'extended' Aug 8, 2019
@rhaschke
Copy link
Contributor

rhaschke commented Aug 8, 2019

@henningkayser, could you please extend the main comment to argue why you want to add this pose?
This will help in future to understand its need.

@rhaschke rhaschke merged commit 168f352 into moveit:melodic-devel Aug 8, 2019
@fwalch
Copy link

fwalch commented Aug 8, 2019

This pose violates the joint limits in joint 4. This is in the URDF, so I'm surprised this isn't flagged by MoveIt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants