install: Add i2c enabler to make-prep.sh #886
Conversation
Codecov Report
@@ Coverage Diff @@
## master #886 +/- ##
==========================================
+ Coverage 77.08% 77.08% +<.01%
==========================================
Files 87 87
Lines 3783 3780 -3
Branches 506 504 -2
==========================================
- Hits 2916 2914 -2
+ Misses 794 793 -1
Partials 73 73
Continue to review full report at Codecov.
|
|
Relate-to: WebThingsIO/addon-list#54 |
image/make-prep.sh
Outdated
| @@ -283,6 +317,7 @@ main() { | |||
| echo " IMG_FILENAME = ${IMG_FILENAME}" | |||
| echo " PREP_FILENAME = ${PREP_FILENAME}" | |||
| echo "ENABLE_CONSOLE = ${ENABLE_CONSOLE}" | |||
| echo "ENABLE_I2C = ${ENABLE_I2C}" | |||
There was a problem hiding this comment.
nit: The = are lined up on the other prints
|
If you're ok to enable i2c in default images, that will be great, then I will update patch to replace by --no-i2c option to disable it. |
|
Yeah - I think that makes sense. It won't go out in the 0.4.0 release, but I don't see any reason why it shouldn't be enabled by default. |
It should work with default config.txt where line is commented. This is helpful for using generic-sensors-addons: https://discourse.mozilla.org/t/creating-i2c-add-on/26696/4 URL: WebThingsIO#886 Change-Id: Ifb8006ded46ce78e537b1a5bf74453fcd635abb8 Signed-off-by: Philippe Coval <[email protected]>
rzr
force-pushed
the
sandbox/rzr/review/i2c/master
branch
from
77a4506
to
6397af9
Compare
It should work with default config.txt where line is commented. This is helpful for using generic-sensors-addons: https://discourse.mozilla.org/t/creating-i2c-add-on/26696/4 URL: WebThingsIO#886 Change-Id: Ifb8006ded46ce78e537b1a5bf74453fcd635abb8 Signed-off-by: Philippe Coval <[email protected]>
rzr
force-pushed
the
sandbox/rzr/review/i2c/master
branch
2 times, most recently
from
2942de2
to
cf72769
Compare
|
Hi, I checked on master (also with --no-i2c), so it should be safe to merge for v0.4.1 |
ghost
removed
the
Should work with default config.txt where line is commented.
This is needed for building generic-sensors-addons:
https://discourse.mozilla.org/t/creating-i2c-add-on/26696/4
Change-Id: Ifb8006ded46ce78e537b1a5bf74453fcd635abb8
Signed-off-by: Philippe Coval [email protected]