Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix constant recompilation by upgrading grpcio-sys to 0.5.3 #688

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Fix constant recompilation by upgrading grpcio-sys to 0.5.3 #688

merged 1 commit into from
Jun 26, 2020

Conversation

AzureMarker
Copy link
Contributor

Description

Fixes recompiling grpcio-sys on every build. See tikv/grpc-rs#449

Testing

Only affects non-linux platforms. Run cargo check twice and it should only compile grpcio-sys once.

Issue(s)

N/A

fzzzy
fzzzy approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@fzzzy fzzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fzzzy fzzzy merged commit 8a35bd3 into mozilla-services:master Jun 26, 2020
@AzureMarker AzureMarker deleted the fix/grpcio-sys-recompile branch June 29, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzzzy fzzzy fzzzy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AzureMarker @fzzzy