Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we should try and get information about arguments supplied as SpreadElement #214

Open
mozfreddyb opened this issue Nov 4, 2022 · 1 comment

Comments

@mozfreddyb
Copy link
Collaborator

Before #211 when looking for the second argument (i.e., arguments[1]), we hit index-out-of-bounds if the arguments are supplied as a SpreadElement (insertAdjacentHTML(...args)). With #211 fixed, we'll stop erroring but skip the check.

This issue here is filed to to identify how much we can find out about said SpreadElement and maybe do some checking on it's correct element.
This is easy for the built-in rules and if the first and only argument is the SpreadElement. But it gets obviously harder if we look for the Nth element where the supplied arguments are a mix of positioned and Spread. The built-in rules only ever check for position 0 and 1 (e.g., document.write and insertAjdacentHTML) though.

This is a follow-up to #211.

@mozfreddyb
Copy link
Collaborator Author

This requires some help. But I promise this won't be easy. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant