-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The 4.1.0 version contains a BC break #252
Comments
More details would be cool and preferred instead of me looking into your CI failure logs (which are public, but hey...). |
Apparently, d9704a7 mentions @mozfreddyb my {
"root": true,
"extends": [
"standard",
"plugin:eslint-comments/recommended",
"plugin:no-unsanitized/DOM",
"plugin:unicorn/recommended"
],
"rules": {}
} when updating to 4.1.0, eslint reported an error saying that it could not find the configuration |
I see. Thank you. I'm pretty sure that's my mistake. It looks like I should have bumped the version to 5.x instead of 4.1.0 then, when including the that commit. Sorry this is breaking for you. Can you rewrite your eslint config to fix this on your end? |
My own config is already fixed (the PR referencing this issue in StackExchange is not my project, but another impacted project). I might be great to make a bugfix release adding |
@mozfreddyb I submitted a PR with a BC layer |
Extending
plugin:no-unsanitized/DOM
in.eslintrc
does not work anymore when upgrading from 4.0.2 to 4.1.0 (which is supposed to be backward compatible according to semver)The text was updated successfully, but these errors were encountered: