Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 4.1.0 version contains a BC break #252

Closed
stof opened this issue Sep 18, 2024 · 5 comments
Closed

The 4.1.0 version contains a BC break #252

stof opened this issue Sep 18, 2024 · 5 comments

Comments

@stof
Copy link
Contributor

stof commented Sep 18, 2024

Extending plugin:no-unsanitized/DOM in .eslintrc does not work anymore when upgrading from 4.0.2 to 4.1.0 (which is supposed to be backward compatible according to semver)

@mozfreddyb
Copy link
Collaborator

More details would be cool and preferred instead of me looking into your CI failure logs (which are public, but hey...).

@stof
Copy link
Contributor Author

stof commented Sep 23, 2024

Apparently, d9704a7 mentions Rename configurations as an intended change of the commit. But this is a BC break.

@mozfreddyb my .eslintrc.json file was looking like that when using 4.0.2 (omitting the configuration of rules as it is not relevant in that case):

{
    "root": true,
    "extends": [
        "standard",
        "plugin:eslint-comments/recommended",
        "plugin:no-unsanitized/DOM",
        "plugin:unicorn/recommended"
    ],
    "rules": {}
}

when updating to 4.1.0, eslint reported an error saying that it could not find the configuration plugin:no-unsanitized/DOM. To make it work, I had to change that to plugin:no-unsanitized/recommended-legacy.

@mozfreddyb
Copy link
Collaborator

I see. Thank you. I'm pretty sure that's my mistake. It looks like I should have bumped the version to 5.x instead of 4.1.0 then, when including the that commit.

Sorry this is breaking for you. Can you rewrite your eslint config to fix this on your end?
I currently do not have the cycles to undo the change in a 4.x bugfix release in the near future.

@stof
Copy link
Contributor Author

stof commented Sep 23, 2024

My own config is already fixed (the PR referencing this issue in StackExchange is not my project, but another impacted project).

I might be great to make a bugfix release adding DOM as an alias for recommended-legacy config. And the release notes for 4.1.0 should at least be updated to mention that.

@stof
Copy link
Contributor Author

stof commented Sep 23, 2024

@mozfreddyb I submitted a PR with a BC layer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants