Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources from different origin but same protocol should load #55

Closed
3 tasks done
Gozala opened this issue Aug 7, 2018 · 5 comments
Closed
3 tasks done

Resources from different origin but same protocol should load #55

Gozala opened this issue Aug 7, 2018 · 5 comments

Comments

@Gozala
Copy link
Contributor

Gozala commented Aug 7, 2018

Several issue were reported that seem to prevent embedding or loading content from same protocol but a different origin:

@lidel
Copy link
Contributor

lidel commented Aug 13, 2018

Clarification for drive-by visitors: this issue is about step 4 from quoted issue.

A better illustration of the issue (red == load failed):

screenshot_27

@Gozala
Copy link
Contributor Author

Gozala commented Aug 15, 2018

Just tested and #69 does fix dweb://foo/ example that embeds <img src="dweb://html/dot.svg" />. Will confirm video next.

@Gozala
Copy link
Contributor Author

Gozala commented Aug 15, 2018

Also quoting issue pointed out in #62 by @willemneal here, which is caused by the same issue

Currently dweb links don't have an effect. I'm sure this would work by registering an on click function for each link, but I thought it would just work with <a href="dweb://async">async</a> since it works with other protocols.

@Gozala
Copy link
Contributor Author

Gozala commented Aug 15, 2018

Verified that #69 also addresses example with embedded video.

@lidel
Copy link
Contributor

lidel commented Aug 15, 2018

Just confirmed it works as expected, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants