Skip to content

Commit

Permalink
Remove check about Remote Settings group_check_enabled
Browse files Browse the repository at this point in the history
  • Loading branch information
leplatrem committed Jan 17, 2022
1 parent de9221f commit b66fb22
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
10 changes: 2 additions & 8 deletions normandy/recipes/exports.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,14 +127,8 @@ def check_config(self):
for r in signer_config["resources"]
if r["source"]["bucket"] == bucket and r["source"]["collection"] == collection
]
review_disabled = (
len(normandy_resource) == 1
and not normandy_resource[0].get(
"to_review_enabled", signer_config["to_review_enabled"]
)
and not normandy_resource[0].get(
"group_check_enabled", signer_config["group_check_enabled"]
)
review_disabled = len(normandy_resource) == 1 and not normandy_resource[0].get(
"to_review_enabled", signer_config["to_review_enabled"]
)
if not review_disabled:
raise ImproperlyConfigured(
Expand Down
1 change: 0 additions & 1 deletion normandy/recipes/tests/test_exports.py
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,6 @@ def test_check_connection(self, rs_settings, requestsmock):
"collection": "normandy-recipes-capabilities",
},
"to_review_enabled": False,
"group_check_enabled": False,
},
],
}
Expand Down

0 comments on commit b66fb22

Please sign in to comment.