-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter Object: Addon #2104
Comments
@mythmon @rehandalal, I have a few questions about this one. I see two different representations of addons on the filter expressions. One looks like The other I see is something like Also, the addon string looks different between these two things. What is the difference between these two items? |
If you are seeing
{
"id": "{446900e4-71c2-419f-a6a7-df9c091e268b}",
"isActive": true,
"name": "Bitwarden - Free Password Manager",
"type": "extension",
"version": "1.42.2",
"installDate": "2020-02-21T00:16:14.000Z"
} A filter like For example, if we want to test out a new password manager feature, we might exclude users that already have a well known password manager. In this case we want to know if it is enabled, because if it is disabled they aren't using it. In this case we'd use Another example would be trying to mitigate the damage that a malware add-on has done. In this case, we would want to test if the add-on is present, even if it was disabled (since it could have done the damage and then disabled itself). In this case we'd just use |
OK thanks for the clarification. |
2136: Add addon filter objects r=rehandalal a=uhlissuh fixes #2104 So, splitting these into two filter objects came from Rehan, which I thought was a good idea. He mentioned seeing about having them share some code, because there is duplication here, and I kinda looked at that for a while and arrived at wondering if we will really gain much here trying to have these two share code? There's only two that are shaped like this right now. There isn't a clear thing I could pull out, maybe someone sees something. Perhaps that's an argument for making them one filter? Co-authored-by: Alissa Sobo <[email protected]>
We need a filter object for filtering for the presence of an addon by its addon id. I think if we want to exclude an addon we will have to combine this with #2105
The text was updated successfully, but these errors were encountered: