Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructors for RTC Encoded Frames with metadata #1009

Closed
guidou opened this issue Apr 15, 2024 · 2 comments
Closed

Constructors for RTC Encoded Frames with metadata #1009

guidou opened this issue Apr 15, 2024 · 2 comments

Comments

@guidou
Copy link

guidou commented Apr 15, 2024

@smaug----
Copy link
Collaborator

@jan-ivar does this need just a spec pr review?

@jan-ivar
Copy link
Member

LGTM. Unfortunately, RTCEncodedVideoFrame is mutable, unlike its cousin EncodedVideoChunk, so the two will likely never merge, in spite of the WebIDL comment suggesting so.

This is a copy-constructor to support client forwarding / fan-out use cases that need to modify metadata without TOKTOU issues. It's basically encoded-frame forwarding instead of packet-forwarding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants