Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main window disappears after being unminimized #1757

Closed
jojoman02 opened this issue Apr 2, 2015 · 21 comments
Closed

main window disappears after being unminimized #1757

jojoman02 opened this issue Apr 2, 2015 · 21 comments
Labels
os:mac priority:stalled

Comments

@jojoman02
Copy link

Steps to reproduce:

  1. under OSX dock preferences enable "minimize windows into application icon"
  2. start playing a video in MPV and pause it
  3. enable "stay to top" SHIFT+T
  4. minimize the window
  5. attempt to unminimize the window by clicking the application icon.
  6. watch as window unminimize and become hidden at the end of the unminimize animation

osx version 10.10.2 and 10.10.3

edit: updated with additional data to better reproduce bug
@ghost ghost added the os:mac label Apr 2, 2015
@es0phagus es0phagus mentioned this issue Apr 11, 2015
Closed
@es0phagus
Copy link

Yeah, it seems to only occur when "minimize windows into application icon" option is ticked in Dock options.

@AirPort
Copy link

AirPort commented Apr 12, 2015

Can't reproduce on my machine (MBP mid 2010, nVidia GPU) with Os X 10.10.3. Could it be a system bug solved in the last version, or maybe something related to video drivers?

@es0phagus
Copy link

Not solved, I've just updated to latest OS X

@jojoman02
Copy link
Author

window still seems to be somewhere. if you hit F on keyboard (to fullscreen) it works... and hitting F takes it back to normal size and then it's visible.

@es0phagus
Copy link

^ that is a decent workaround but not a fix, but thanks.

@ghost
Copy link

ghost commented Apr 15, 2015

What mpv version? Try git master.

@Argon-
Copy link
Member

Argon- commented Apr 15, 2015

Can't reproduce it as well using 10.10.2 and current master (e6d7e55).
Maybe try it with --no-config and in case it works that way try to find the problematic option in your config.

@es0phagus
Copy link

version git-8fff125.

Git master?

How do I do the 'no config' thing? what do I enter into the config file exactly

@Argon-
Copy link
Member

Argon- commented Apr 15, 2015

Where do you have your version of mpv from?

@es0phagus
Copy link

Where should I be getting the version from? I downloaded my mpv from the main site.

@jojoman02
Copy link
Author

This build from mpv.io has the issue:

64-bit binary (by ChrisK) [OS X 10.8+] http://sva.wakku.to/~chris/mpv_builds/mpv_latest.zip

I removed mpv and reinstalled it via homebrew. Now there is no issue. I suppose ChrisK needs to update his build.

@Argon-
Copy link
Member

Argon- commented Apr 15, 2015

Funny, I just tried this version (and http://sva.wakku.to/~chris/mpv_builds/mpv_20150329202708_git-8fff125.tar.bz2 which is apparently the one es0phagus is using) and both work for me just fine.
@es0phagus if the problem still persists after upgrading to a more recent version I'd suggest you try to rename your config (so mpv won't load it) and check if the problem is still there.
--no-config is a flag used when invoking mpv from the Terminal.

@es0phagus
Copy link

I upgraded and it still persists. Where is the config file located again? I've forgotten.

@jojoman02
Copy link
Author

After some investigation it appears to be a bug related to the stay on top option, not any particular build as i've just replicated it with latest mpv from homebrew.

@es0phagus
Copy link

Yup, after I removed "ontop" from the config file the bug ceases.

@jojoman02 jojoman02 mentioned this issue Apr 28, 2015
Closed
@es0phagus
Copy link

Any chance of this being fixed? Still persists on El Capitan. If "on top" isn't enabled, then it functions properly, but if it is, then it exists.

@jojoman02
Copy link
Author

yep, i've noticed some apps (e.g. vox) handle on top correctly. idk how.

On Sun, Oct 4, 2015 at 10:58 AM es0phagus [email protected] wrote:

Any chance of this being fixed? Still persists on El Capitan.

—
Reply to this email directly or view it on GitHub
#1757 (comment).

Akemi added a commit to Akemi/mpv that referenced this issue Jan 19, 2017
@Akemi
cocoa: fix vanishing window on deminiaturizing with ontop
2355e3e 
when the window level is set to something different than
NSNormalWindowLevel and the window is miniaturized, it will vanish when
deminiaturized. setting NSNormalWindowLevel before miniturizing and
setting the wanted level after deminiaturizing to work around this bug.

Fixes mpv-player#1757
@Akemi
Copy link
Member

Akemi commented Jan 19, 2017 •
edited
Loading

this should work around the bug.

Akemi added a commit to Akemi/mpv that referenced this issue Jan 19, 2017
@Akemi
cocoa: fix unwanted behavior with ontop
fda4bab 
setting a window level other than NSNormalWindowLevel always sets
NSWindowCollectionBehaviorTransient, which prevents certain things to
work properly. examples are automatic switching to the active Space when
mpv is made active and (de-)miniaturizing. latter always lead to a
vanishing window.

Fixes mpv-player#1757 mpv-player#1884
@Akemi
Copy link
Member

Akemi commented Jan 19, 2017 •
edited
Loading

okay instead of working around the bug, i found the cause and a way to fix it. this also fixes #1884. @jojoman02 since you reported both bugs can you confirm it fixes it for you too?

Akemi added a commit to Akemi/mpv that referenced this issue Jan 19, 2017
@Akemi
cocoa: fix unwanted behavior with window level other than the default
b6b0bc4 
setting a window level other than NSNormalWindowLevel always sets
NSWindowCollectionBehaviorTransient, which prevents certain things to
work properly. examples are automatic switching to the active Space when
mpv is made active and (de-)miniaturizing. latter always lead to a
vanishing window.

Fixes mpv-player#1757 mpv-player#1884
@es0phagus
Copy link

es0phagus commented Jan 19, 2017 via email

Akemi added a commit to Akemi/mpv that referenced this issue Jan 19, 2017
@Akemi
cocoa: fix unwanted behavior with window level other than the default
5a0de80 
setting a window level other than NSNormalWindowLevel always sets
NSWindowCollectionBehaviorTransient, which prevents certain things to
work properly. examples are automatic switching to the active Space when
mpv is made active and (de-)miniaturizing. latter always lead to a
vanishing window.

Fixes mpv-player#1757 mpv-player#1884
Akemi added a commit to Akemi/mpv that referenced this issue Jan 19, 2017
@Akemi
cocoa: fix unwanted behavior with window level other than the default
b8c84d9 
setting a window level other than NSNormalWindowLevel always sets
NSWindowCollectionBehaviorTransient, which prevents certain things to
work properly. examples are automatic switching to the active Space when
mpv is made active and (de-)miniaturizing. latter always lead to a
vanishing window.

Fixes mpv-player#1757 mpv-player#1884
@Akemi
Copy link
Member

Akemi commented Jan 19, 2017

you have to build it yourself or you can try this.

@Akemi Akemi closed this as completed in 954625c Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
os:mac priority:stalled
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@AirPort @Argon- @Akemi @jojoman02 @es0phagus