Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opengl-hq debanding doesn't work with OS X hwdec (videotoolbox) #2831

Closed
kiririn opened this issue Feb 16, 2016 · 7 comments
Closed

opengl-hq debanding doesn't work with OS X hwdec (videotoolbox) #2831

kiririn opened this issue Feb 16, 2016 · 7 comments

Comments

@kiririn
Copy link

kiririn commented Feb 16, 2016

Not sure if it's even supposed to work but examples are below. I took the screenshots with Ctrl+s.

With hwdec:
mpv [HorribleSubs]\ Non\ Non\ Biyori\ Repeat\ -\ 04\ [720p].mkv --no-config --start=14:39 --pause --vo=opengl-hq --hwdec=auto
https://my.mixtape.moe/jmoyja.jpg

Without:
mpv [HorribleSubs]\ Non\ Non\ Biyori\ Repeat\ -\ 04\ [720p].mkv --no-config --start=14:39 --pause --vo=opengl-hq
https://my.mixtape.moe/bijans.jpg

Version: mpv git-0af5335

@ghost
Copy link

ghost commented Feb 16, 2016

It's supposed to work.

What about mpv file.mkv --vf=format=nv12 --vo=opengl-hq?

@kiririn
Copy link
Author

kiririn commented Feb 16, 2016

What about mpv file.mkv --vf=format=nv12 --vo=opengl-hq?

That doesn't really do anything that I can see but if I add --hwdec=auto I get this:

Opening video filter: [format fmt=nv12]
AO: [coreaudio] 44100Hz stereo 2ch floatp
Using hardware decoding (videotoolbox).
Using conversion filter.
Image formats incompatible or invalid.
Video filter chain:
[in] 1280x720 videotoolbox bt.709/limited CL=mpeg2/4/h264
[scale] ??? [a] <---
[format] ???
[out] ???
Falling back to software decoding.
[ffmpeg/video] h264: co located POCs unavailable
[ffmpeg/video] h264: reference picture missing during reorder
[ffmpeg/video] h264: Missing reference picture, default is 8
Using conversion filter.
VO: [opengl-hq] 1280x720 nv12

@ghost
Copy link

ghost commented Feb 16, 2016

Anyway, post log with -v and videotoolbox.

@kiririn
Copy link
Author

kiririn commented Feb 16, 2016

Log: http://sprunge.us/dgaQ

@ghost
Copy link

ghost commented Feb 16, 2016

Without the vf-format please.

@kiririn
Copy link
Author

kiririn commented Feb 16, 2016

Here: http://sprunge.us/KIVQ

@ghost
Copy link

ghost commented Feb 16, 2016

Thanks. The output looks as expected, so I suspect a subtle issue with the use of texture rectangles. (The only thing different to the sw case.)

@ghost ghost closed this as completed in 57c31f4 Feb 18, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant