-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CD Graphics video [lavc:cdgraphics] skips forward, gets off-sync with Karaoke track #3027
Comments
Please provide files. |
So a frame can "Freeze" for a few seconds. The playback core can't know if it's a discontinuity or not. (If there's a jump, should it wait for a few seconds? Or consider it as a discontinuity?) |
Packet duration? |
Completely useless, as usual. |
Will look is this bug in demuxer... |
Even then, many external decoders I have to deal with will not pass through pkt_duration or even know a correct value of it, so this is not a general solution. |
PS: also, mpv does this after filters, and filters are unlikely to pass this through. |
I per-packet/frame discontinuity flag would be a good concept, because the demuxer knows best whether something is a timestamp reset or not. A decoder could also set it if frames are dropped/packets are invalid. But unfortunately it doesn't exist in ffmpeg, and even if it were introduced, wouldn't be consistent. |
@clintonthegeek can you provide a sample file so I can test it with #5792 |
SC8322-01 - Moody Blues, The - I'm Just A Singer In A Rock And Roll Band.zip This file had the problem when I initially reported the bug. |
Interesting, I've never seen cdg before. How do you play the files together with mpv? |
Once you open the .cdg any .mp3 (or, perhaps, other audio format?) is sideloaded as long as it shares the same filename and is in the same folder. :) |
When playing a .cdg file (graphic file displaying lyrics for karaoke music) and accompanying audio track the seekbar skips forward immediately to the next animation in the file instead of pausing for the appropriate duration. This results in the lyrics getting off-sync with the audio track, and mpv skipping over intros, instrumental sections, or any part of a song where the graphics should be paused.
The text was updated successfully, but these errors were encountered: