-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mpv blue screen, on latest build #3293
Comments
checkout to 4ce5302 , and rebuild, everything goes fine. |
Bug is caused by an (unintended) change in behavior to subtitle color management. I'm thinking it might be time to revisit this behavior, since pass_colormanage has grown to be much more than a simple routine for adapting colors (and more of a big auto-detection heuristic function). |
haasn
added a commit
to haasn/mp
that referenced
this issue
Jun 29, 2016
This involves multiple changes: 1. Brightness metadata is split into nominal peak and reference peak. For a quick and dirty explanation: nominal peak is the brightest value that your color space can represent (i.e. the brightness of an encoded 1.0), and reference peak is the brightest value that actually occurs in the video. 2. vo_opengl uses a new decision logic to figure out the right nom_peak and ref_peak for all situations. It also does a better job of picking the right target gamut/colorspace to use for the OSD. (Which still is and still should be treated as sRGB). This change in logic also fixes mpv-player#3293 en passe. 3. Since it was growing rapidly, the logic for auto-guessing / inferring the right colorimetry configuration (in pass_colormanage) was split from the logic for actually performing the adaptation (now pass_color_map). Right now, the new logic doesn't do a whole lot since HDR metadata is still ignored (but not for long).
haasn
added a commit
to haasn/mp
that referenced
this issue
Jun 29, 2016
This involves multiple changes: 1. Brightness metadata is split into nominal peak and signal peak. For a quick and dirty explanation: nominal peak is the brightest value that your color space can represent (i.e. the brightness of an encoded 1.0), and signal peak is the brightest value that actually occurs in the video (i.e. the brightest thing that's displayed). 2. vo_opengl uses a new decision logic to figure out the right nom_peak and sig_peak for all situations. It also does a better job of picking the right target gamut/colorspace to use for the OSD. (Which still is and still should be treated as sRGB). This change in logic also fixes mpv-player#3293 en passant. 3. Since it was growing rapidly, the logic for auto-guessing / inferring the right colorimetry configuration (in pass_colormanage) was split from the logic for actually performing the adaptation (now pass_color_map). Right now, the new logic doesn't do a whole lot since HDR metadata is still ignored (but not for long).
haasn
added a commit
to haasn/mp
that referenced
this issue
Jul 3, 2016
This involves multiple changes: 1. Brightness metadata is split into nominal peak and signal peak. For a quick and dirty explanation: nominal peak is the brightest value that your color space can represent (i.e. the brightness of an encoded 1.0), and signal peak is the brightest value that actually occurs in the video (i.e. the brightest thing that's displayed). 2. vo_opengl uses a new decision logic to figure out the right nom_peak and sig_peak for all situations. It also does a better job of picking the right target gamut/colorspace to use for the OSD. (Which still is and still should be treated as sRGB). This change in logic also fixes mpv-player#3293 en passant. 3. Since it was growing rapidly, the logic for auto-guessing / inferring the right colorimetry configuration (in pass_colormanage) was split from the logic for actually performing the adaptation (now pass_color_map). Right now, the new logic doesn't do a whole lot since HDR metadata is still ignored (but not for long).
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mpv version:
mpv.conf:
error log:
video card: intel
video driver: xserver-xorg-video-intel
OS: debian 9 (testing)
reproduce: play any movie, and move mouse to player window.
reproducibility: 100%
I just git pull mpv, and rebuild.
and git update to: 4ce5302..9ca1592
The text was updated successfully, but these errors were encountered: