macOS High DPI monitor and autofit options

[sCreami]

I thought the relative display size with retina displays was fixed but it seems not.

mpv version and platform

macOS 10.12 Sierra
git master

Expected behavior

When using a relative % as option, the window should have this % in height.

Actual behavior

Setting autofix=50% will result in a ±25% window.

[cc @Akemi as always]

[sCreami]

Oh I forgot to mention but it's when using --no-hidpi-window-scale so maybe it's an expected behavior?

[Akemi]

yeah i am kinda aware of this, though i thought it was the other way around. i just assumed it's like this but never tested. as a user it's unexpected. as a dev i don't know when autofit was set to a relative metric since i just get the final size in pixel.

maybe @wm4 knows of a way how i can get to know, in the vo backend, when a relative metric was set and i should force --hidpi-window-scale appropriately?

[ghost]

vo_calc_window_geometry processes the option using the supplied arguments, that's all I know.

[Akemi]

this commit should fix it (branch). since @wm4 added a dpi scale aware function to calculate the initial window position and size (a35a5bb), i could get rid of a fair amount of 'duplicate' code.

i tested the cases from #3867 again and they are also still working. maybe @SteveJobzniak wants to have a try too.

[sCreami]

Works fine 👍

[ghost]

@Akemi I have a non-Retina MacBook Pro 2010, so I guess that won't work for testing if this is a Retina-only patch.

[Akemi]

both cases are affected by this change. i was just interested if the cases from #3867 still work for you.

[ghost]

@Akemi Oh yeah that commit seems to change a lot. I'm building mpv with your new commit now to see if geometry still works.

[ghost]

@Akemi All geometry test cases from the previous ticket work. I tested 0:0 (top left), 100%:100% (bottom right), 50%:50% (center), +20-20 (bottom left with negative offset). I tested with hidpi-window-scale=yes and =no. But no retina screen here so dunno if that did anything.

Well, your new patch works with non-retina displays! 👍 :)