-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Property window-scale
is incorrect after fullscreen
#4323
Labels
Comments
Same here on 10.12.4 and git master, actually I noticed it too the other day and I was about to open an issue. |
Akemi
added a commit
to Akemi/mpv
that referenced
this issue
Apr 15, 2017
due to the System inherent fullscreen animation the option and the actual fullscreen state can be out of sync, leading to a wrongly reported unfs window size in the time of the animation. just always fall back to the window size we keep track of when we either are in fullscreen or are currently switching to it. Fixes mpv-player#4323
this should fix it. will merge tomorrow for the case anyone wants to test it beforehand. |
Akemi
added a commit
to Akemi/mpv
that referenced
this issue
Apr 17, 2017
due to the System inherent fullscreen animation the option and the actual fullscreen state can be out of sync, leading to a wrongly reported unfs window size in the time of the animation. just always fall back to the window size, we keep track of, when we either are in fullscreen or are currently switching to it. Fixes mpv-player#4323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mpv version and platform
OSX 10.11
Reproduction steps
window-scale
window-scale
window-scale
(See script below)
Expected behavior
window-scale
from step 3 and 5 should match.Actual behavior
window-scale
in step 1 and 5 match.Note that using
mp.observe_property
will only return correctwindow-scale
values and not exhibit this problem.Log file
Test made with this script: https://gist.github.com/Argon-/aadd9b337ca4d419b492d369ec99553b
After pressing
i
it will printwindow-scale
, go to fullscreen and printwindow-scale
again as well as start a timer that will printwindow-scale
a third time after 2 seconds, then quit.With
-v
: https://gist.github.com/Argon-/e4c27a670fde61b4ac385e2a0ef6570cSample files
Works for me with every file tested, including pictures (don't forget
keep-open
in this case). I recommend a file that does not have awindow-scale
of 1 when normally opened and when in fullscreen, otherwise this bug is not noticeable.The text was updated successfully, but these errors were encountered: