-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cycle-values fix/enhancement #5772
Comments
The current behavior is pretty much due to options like "aspect", which tend to introduce some rounding etc., which would break cycle-values if it behaved like you wanted it to behave. Not sure if this could be hacked around by now. |
If I understand it right, adding a new input command, say, I updated my script so that it works exactly how I'd like
On the side note, where can I ask a question regarding mpv? I tried looking trough issues, reading manual and even asking on /g/mpv - I couldn't find the answer to my question so far. Since I already went this far, I'll post the qestion here (I can delete this part of my comment after I'll get an answer - either to my question, or to where should I ask it instead). Sorry for completely offtopic talk in the issue comments, but I'm all out of ideas where to ask instead. Opening a new issue just to ask a question seems like even worse idea. Is it possible to either call a function from one script in another while reusing the instance, or call a script's function by command line arguments? Example below. script.lua:
call_a_function_from_script.lua
command line args:
|
Questions normally go on IRC. See: https://mpv.io/community/ Scripts are completely isolated from each other. They can only talk via There's no way to call script functions from command lines. But there's --script-opts, which can be read as property by scripts or via the |
Also I'll probably take a look again at changing cycle-values to something that's generally more expected. |
Thank You very much for your answer. I'll move with my next questions to IRC. Let me know If I should remove the offtopic part of my previous comment. It's most certainly not related to this issue, but I'm generally against deleting anything anywhere - someone may make use of those informations. For instance, I had no idea that mpv has it's own IRC channel. Regarding the issue - it's definitely not something of a high priority, especially since I made a script that solves the problem for now. I'll leave the decision whether to close the issue to You, probably this will be my last comment on this topic. |
cycle-values
should either be fixed/enhanced, or another input command should be addedAs of now, neither
cycle
norcycle-values
allows for toggling a multi-state value (more than 2 possible values) correctly. Consider the following example:input.conf:
c cycle-values keep-open yes no
case 1:
mpv --keep-open=no
- values will be cycled properly -yes
,no
,yes
,no
, etc.case 2:
mpv --keep-open=yes
- values won't be cycled properly -yes
,yes
,no
,yes
, etc.I'd like to see either cycle-values 'fixed' (I'm not sure if current behaviour is desired), or a new input command that wound prevent choosing the same value twice in a row.
I wrote a workaround script for that, but I think that it should be a built-in mpv input command. It's probably really simple to implement, but I don't know whether I should make it a new input command or change the behaviour of existing one, nor I have any experience in contributing to mpv. Here's the script, if anyone is interested:
The text was updated successfully, but these errors were encountered: