Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected crash on waking from sleep #6062

Closed
cheeexq opened this issue Aug 9, 2018 · 2 comments
Closed

Unexpected crash on waking from sleep #6062

cheeexq opened this issue Aug 9, 2018 · 2 comments
Labels

Comments

@cheeexq
Copy link

cheeexq commented Aug 9, 2018

mpv version and platform

mpv version: current master + #5953
Platform: macOS 10.14 beta (18A353d)

Reproduction steps

Playback on external display (connected via HDMI), in fullscreen mode and paused.
Leave the devices idle for several minutes for the system to go to sleep.
Wake the MacBook up to find that mpv has crashed.

Expected behavior

Playback window remains intact after waking up.

Actual behavior

Playback window crashes.

Log file

System crash report: https://0x0.st/s4f9.txt

Sample files

None.

@Akemi Akemi added the os:mac label Aug 9, 2018
@Akemi
Copy link
Member

Akemi commented Aug 9, 2018

yeah i noticed that recently too when i watched something on my TV. i will look into it this evening when i get back from work.

Akemi added a commit to Akemi/mpv that referenced this issue Aug 9, 2018
instead of force unwrapping and chaining the optional vars in our
containsMouseLocation function, safely unwrap and guard the resulting
var.

Fixes mpv-player#6062
@Akemi
Copy link
Member

Akemi commented Aug 9, 2018

should be fixed with #6064.

@sfan5 sfan5 closed this as completed in 6bf0edc Aug 11, 2018
jeeb pushed a commit to jeeb/mpv that referenced this issue Sep 29, 2018
instead of force unwrapping and chaining the optional vars in our
containsMouseLocation function, safely unwrap and guard the resulting
var.

Fixes mpv-player#6062

(cherry picked from commit 6bf0edc)
jeeb pushed a commit to jeeb/mpv that referenced this issue Sep 29, 2018
instead of force unwrapping and chaining the optional vars in our
containsMouseLocation function, safely unwrap and guard the resulting
var.

Fixes mpv-player#6062

(cherry picked from commit 6bf0edc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants