osc: fix forced-window detection during scaling #4102
Conversation
Relying on "video" property being "no" isn't good enough because when mpv starts playing a new file for a split second "video" is set to "auto", which results in incorrect scaling being applied to a forced window at this moment. Then "video" property is set to "no" and correct scaling is applied, which results in scaling differences. User sees this as OSC glitches. Solve the problem by checking "force-window" option when trying to detect forced-window mode. Closes #4081.
|
I really don't think this is the right fix. If your point is always have consistent osc scaling even with video=no, just set scaleforcedwindow to 1 on your side. |
This also makes no sense, video=no without force-window doesn't create a window, so of course there's no osc. Anyway, this isn't a bug, this is intended behavior. Just set scaleforcedwindow=1 if you don't like it. |
It is intended to expect video property to be "no" with forced window, when it's not always the case? |
|
scaleforcedwindow being different from scalewindowed and scalefullscreen is the intended behavior. I wasn't the one to do it, but I understand why it's different. If you want consistency, set the same value for all of them. What's so hard? |
|
This is NOT about these 3 values being different. This is about osc.lua using incorrect checks to choose what scaling to apply. Have you read the commit message? Nothing there mentions 'consistency'. |
|
I don't have the patience to keep repeating myself. Ask @ChrisK2 if you want to change the default scaleforcedwindow to 1. This PR is fixing the wrong thing. |
|
I don't want to change scaleforcedwindow. I explicitly said so and my PR doesn't try to do it. I think you are mistaken here. |
Agree, I accidentally broke the case when there is actual video and |
Will still hide playlist items with long enough filenames and osd-font-size but not as soon. osc messages should now preserve their scaling with fullscreen toggling and cycling through audio-only files and files with video. Closes mpv-player#4081, mpv-player#4083, mpv-player#4102
Will still hide playlist items with long enough filenames and osd-font-size but not as soon. osc messages should now preserve their scaling with fullscreen toggling and cycling through audio-only files and files with video. Closes mpv-player#4081, mpv-player#4083, mpv-player#4102
Will still hide playlist items with long enough filenames and osd-font-size but not as soon. osc messages should now preserve their scaling with fullscreen toggling and cycling through audio-only files and files with video. Closes mpv-player#4081, mpv-player#4083, mpv-player#4102
ghost
Will still hide playlist items with long enough filenames and osd-font-size but not as soon. osc messages should now preserve their scaling with fullscreen toggling and cycling through audio-only files and files with video. Closes mpv-player#4081, mpv-player#4083, mpv-player#4102
Will still hide playlist items with long enough filenames and osd-font-size but not as soon. osc messages should now preserve their scaling with fullscreen toggling and cycling through audio-only files and files with video. Closes mpv-player#4081, mpv-player#4083, mpv-player#4102
|
Fixed in bcb2db0, which didn't close this one for some reason. |
Relying on "video" property being "no" isn't good enough because when
mpv starts playing a new file for a split second "video" is set to
"auto", which results in incorrect scaling being applied to a forced
window at this moment.
Then "video" property is set to "no" and correct scaling is applied,
which results in scaling differences. User sees this as OSC glitches.
Solve the problem by checking "force-window" option when trying to
detect forced-window mode.
Closes #4081.