New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Cubic extension conjugate #398

Open

mratsim opened this issue Jun 24, 2024 · 0 comments

Labels

bug 🪲 correctness 🛂

Owner

mratsim commented Jun 24, 2024

From @yelhousni

constantine/constantine/math/extension_fields/towers.nim

Lines 221 to 225 in ab6fa6a

 func conj*(r: var CubicExt, a: CubicExt) = 

 ## Computes the conjugate out-of-place 

 r.c0.conj(a.c0) 

 r.c1.conjneg(a.c1) 

 r.c2.conj(a.c2)

This is only valid if non-residue is sqrt(-1) and (p-1)/3 is odd which is the case for BLS12-381.

mratsim added bug 🪲 correctness 🛂 labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment