Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground: adding a texture and using it as "normal" slot input results in exceptions #29650

Open
hybridherbst opened this issue Oct 14, 2024 · 1 comment · Fixed by #29652
Labels
Milestone

Comments

@hybridherbst
Copy link
Contributor

hybridherbst commented Oct 14, 2024

Description

Adding a texture and using it as "normal" slot input results in exceptions. I'm not sure if I'm expected to swizzle it down to three components – but I think at least there shouldn't be renderloop-breaking exceptions when not doing that.

Reproduction steps

  1. Drop a texture (any texture) into https://threejs.org/playground
  2. Add a "Texture" node
  3. Connect the output of "Texture" to the "normal" slot
  4. Note exceptions in console

EDIT: Looks like as a workaround, a UV node can be added – in other node-based shader editors UV0 is implicit, so I didn't expect that.
image

Code

Live example

https://threejs.org/playground/

Screenshots

image

Version

latest

Device

Desktop

Browser

Chrome

OS

Windows, MacOS

@hybridherbst
Copy link
Contributor Author

Fyi, #29652 does not close this issue, I just happened to run into this one here while looking at normal maps.
I think it should be reopened!

@Mugen87 Mugen87 added this to the r170 milestone Oct 14, 2024
@sunag sunag reopened this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants