Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Toon Material Browser #15105

Closed
wants to merge 1 commit into from
Closed

Docs: Toon Material Browser #15105

wants to merge 1 commit into from

Conversation

mghini
Copy link
Contributor

@mghini mghini commented Oct 22, 2018

Added material-browser for MeshToonMaterial documentation page

@Mugen87
Copy link
Collaborator

Mugen87 commented Oct 22, 2018

@WestLangley
Copy link
Collaborator

That is not what that material is supposed to look like. One also doesn't use a grass map for a gradient.

Either the example here has issues, or there is a problem with the material.

@Mugen87
Copy link
Collaborator

Mugen87 commented Oct 22, 2018

The grass map is also used for other map types in context of other materials which is not ideal:

image

@takahirox
Copy link
Collaborator

Gradient map should be like "Gradient Mask_B" in http://technical-eden.blogspot.com/2012/01/gradient-mapping-awesome-way-to-get.html

@mrdoob mrdoob added this to the r99 milestone Oct 22, 2018
@WestLangley
Copy link
Collaborator

The grass map is also used for other map types in context of other materials which is not ideal:

I think it would be a worthwhile effort to further improve the docs.

IMHO, In the material examples, you don't need all the menu choices from the base classes to be repeated every time.

@takahirox I have never seen a toon shader that supports hotspots, environment maps, or even maps for that matter... Or multiple lights. (Maybe I am missing something?)

A toon shader can be written in a few lines of code, and IMHO, should not have extended Phong, which is way too flexible. I would have implemented it like MeshMatcapMaterial.

@mrdoob mrdoob modified the milestones: r99, r100 Nov 29, 2018
@mrdoob mrdoob modified the milestones: r100, r101 Dec 31, 2018
@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 11, 2019

A toon shader can be written in a few lines of code, and IMHO, should not have extended Phong, which is way too flexible. I would have implemented it like MeshMatcapMaterial.

I agree. I think we should consider to refactor MeshToonMaterial at some point and also OutlineEffect so it only supports the toon material.

@WestLangley
Copy link
Collaborator

@takahirox I have never seen a toon shader that supports hotspots, environment maps, or even maps for that matter... Or multiple lights. (Maybe I am missing something?)

A toon shader can be written in a few lines of code, and IMHO, should not have extended Phong, which is way too flexible. I would have implemented it like MeshMatcapMaterial.

/ping @takahirox

@takahirox
Copy link
Collaborator

OK, let me revisit MeshToonMaterial. Not sure if OutlineEffect should be specific to toon material tho.

@mrdoob mrdoob modified the milestones: r101, r102 Jan 31, 2019
@mrdoob mrdoob modified the milestones: r102, r103 Feb 28, 2019
@mrdoob mrdoob modified the milestones: r103, r104 Mar 27, 2019
@WestLangley
Copy link
Collaborator

/bump

I think a refactoring of MeshToonMaterial along the lines of MeshMatcapMaterial is worthwhile.

@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 15, 2019

@WestLangley Let's create a separate issue for this 👍 . The PR can be closed now because of #16255

@Mugen87 Mugen87 closed this Apr 15, 2019
@Mugen87 Mugen87 mentioned this pull request Apr 15, 2019
13 tasks
@mrdoob mrdoob removed this from the r104 milestone Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants